Add UI endpoint for deadline callback log visibility#70423
Closed
seanghaeli wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a UI API endpoint
GET /ui/dags/{dag_id}/dagRuns/{dag_run_id}/callbacks/{callback_id}/logsthat returns deadline callback execution logs, streaming NDJSON when requested (same pattern as the task instance log route). Logs are read from remote storage or the local log folder at theexecutor_callbacks/.../triggerer_callbacks/...paths written by #66379; the triggerer now also captures callback trigger output to that path.DeadlineResponsegainscallback_idandcallback_stateso the UI can link a deadline to its callback logs.Backend re-cut of #66610 addressing the review feedback there (streaming response, single exists-only query, depends-level path validation); frontend follows in a separate PR.