Detect linked issues at the end of PR bodies in provider testing issue#70396
Open
shahar1 wants to merge 1 commit into
Open
Detect linked issues at the end of PR bodies in provider testing issue#70396shahar1 wants to merge 1 commit into
shahar1 wants to merge 1 commit into
Conversation
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
July 24, 2026 15:10
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
The provider testing issue generator missed linked issues when the reference was the last thing in the PR body (a common shape: "Fixes character after the number, which does not exist at end of string, so the reference was silently dropped and the release manager had to add the issue to the testing issue by hand (e.g. apache#53843 for the google 22.3.0rc1 issue). A negative lookahead matches the same references without needing a trailing character.
shahar1
force-pushed
the
worktree-fix-linked-issue-regex
branch
from
July 24, 2026 15:12
0924b00 to
f21538d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The provider testing issue generator (
breeze release-management generate-issue-content-providers) silently missed linked issues whose reference is the last thing in the PR body — a common shape, sinceFixes #NNNNNoften sits on the final line.ISSUE_MATCH_IN_BODY(r" #([0-9]+)[^0-9]") requires a non-digit character after the number, which doesn't exist at end of string after the body's lines are joined.Concrete occurrence: in the google 22.3.0rc1 testing issue (#70355), PR #69161 (body ending with
Fixes #53843) was rendered with no linked issues, and the release manager had to add #53843 by hand.Replacing the trailing
[^0-9]with a negative lookahead(?![0-9])matches the same references without requiring a trailing character. Verified against the real #69161 body: the old pattern finds nothing, the new one finds 53843; mid-body references behave identically.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines