Revert Dataform workflow invocation dict normalization (#69161)#70395
Open
shahar1 wants to merge 1 commit into
Open
Revert Dataform workflow invocation dict normalization (#69161)#70395shahar1 wants to merge 1 commit into
shahar1 wants to merge 1 commit into
Conversation
The reverted change was meant to fix apache#53843 (invocation_config believed dropped when workflow_invocation is passed as a dict), but it is a wire-identical no-op: proto-plus already converts nested dicts recursively, and the pre- and post-change requests serialize byte-identically, so the dict path never dropped the config. The reported symptom came from dataform-core 3.0.10-3.0.16 defaulting incremental tables to protected=true (silently disabling full refresh server-side; fixed upstream in core 3.0.17 via dataform-co/dataform#1942). apache#53843 is closed as not planned. The accompanying test only pinned third-party proto-plus conversion behavior, which our testing standards exclude.
boring-cyborg
Bot
added
area:providers
provider:google
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #69161. The change is a provably wire-identical no-op: proto-plus already converts nested dicts recursively, so the pre- and post-change
CreateWorkflowInvocationRequestserialize byte-identically and the dict path never droppedinvocation_config. Unknown fields raiseValueErrorin proto-plus, so a silent drop at this layer was never possible.The symptom reported in #53843 was caused outside Airflow: dataform-core 3.0.10–3.0.16 defaulted incremental tables to
protected: true(dataform-co/dataform#1914), which silently disables full refresh server-side; fixed upstream in core 3.0.17 (dataform-co/dataform#1942). Repos pindataformCoreVersion, which is why the symptom persisted after the upstream fix. #53843 has been closed as not planned accordingly.The accompanying test only pinned third-party proto-plus conversion behavior, which the project's testing standards exclude.
related: #53843
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines