Validate Gemini batch results_folder in the worker that writes results#70393
Open
shahar1 wants to merge 1 commit into
Open
Validate Gemini batch results_folder in the worker that writes results#70393shahar1 wants to merge 1 commit into
shahar1 wants to merge 1 commit into
Conversation
In deferrable mode the results file is written by execute_complete in a resume worker where execute() -- and its results_folder pre-flight check -- never ran. A folder missing there (heterogeneous workers, relative path against a different CWD) surfaced as a raw FileNotFoundError after the billable batch job already succeeded, instead of the operator's clear validation error.
boring-cyborg
Bot
added
area:providers
provider:google
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Summary
In deferrable mode,
GenAIGeminiCreateBatchJobOperator/GenAIGeminiCreateEmbeddingsBatchJobOperatorwrite the results file inexecute_complete(), which runs in a fresh resume worker whereexecute()— and itsresults_folderpre-flight check (moved there by #70362) — never ran. A folder missing in that worker (heterogeneous workers, or a relative path resolved against a different CWD) surfaced as a rawFileNotFoundErrorafter the billable batch job already succeeded.The existing check is extracted into
_validate_results_folder()(raise relocated verbatim) and called both fromexecute()(unchanged fail-fast before creating the job) and from_prepare_results_for_xcom()before downloading, so the process that writes the file is the one that validates the folder.related: #70362
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines