Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ def __init__(
**kwargs,
) -> None:
super().__init__(**kwargs)
if sql_params is None:
sql_params = {}
self.dest_teradata_conn_id = dest_teradata_conn_id
self.destination_table = destination_table
self.source_teradata_conn_id = source_teradata_conn_id
Expand All @@ -86,7 +84,7 @@ def execute(self, context: Context) -> None:
dest_hook = self.dest_hook
with src_hook.get_conn() as src_conn:
cursor = src_conn.cursor()
cursor.execute(self.sql, self.sql_params)
cursor.execute(self.sql, self.sql_params or {})
target_fields = [field[0] for field in cursor.description]
rows_total = 0
if len(target_fields) != 0:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,25 @@ def test_destination_hook(self):
assert hook is op.dest_hook
assert hook.teradata_conn_id == "dest_teradata_conn_id"

def test_sql_params_default_is_applied_at_execution(self, mocked_src_hook):
op = TeradataToTeradataOperator(
task_id="transfer_data",
dest_teradata_conn_id=self.dest_teradata_conn_id,
destination_table=self.destination_table,
source_teradata_conn_id=self.source_teradata_conn_id,
sql=self.sql,
)

assert op.sql_params is None

mock_src_conn = mocked_src_hook.get_conn.return_value.__enter__.return_value
mock_cursor = mock_src_conn.cursor.return_value
mock_cursor.description.__iter__.return_value = []

op.execute({})

mock_cursor.execute.assert_called_once_with(self.sql, {})

def test_execution(self, mocked_src_hook, mocked_dest_hook):
cursor_description = [
["user_id", Decimal, None, 8, 10, 0, False],
Expand Down
1 change: 0 additions & 1 deletion scripts/ci/prek/validate_operators_init_exemptions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -70,5 +70,4 @@ providers/ssh/src/airflow/providers/ssh/operators/ssh_remote_job.py::SSHRemoteJo
providers/standard/src/airflow/providers/standard/operators/bash.py::BashOperator
providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py::TriggerDagRunOperator
providers/standard/src/airflow/providers/standard/sensors/date_time.py::DateTimeSensor
providers/teradata/src/airflow/providers/teradata/transfers/teradata_to_teradata.py::TeradataToTeradataOperator
providers/weaviate/src/airflow/providers/weaviate/operators/weaviate.py::WeaviateIngestOperator