Make the HITLOperator summary extension point public#70391
Open
shahar1 wants to merge 1 commit into
Open
Conversation
apache#70345 turned hitl_summary into a computed property and moved runtime and subclass additions into a private _hitl_summary_extra dict. That left HITLOperator subclasses without a supported way to extend the summary (the pattern the old attribute explicitly documented) and leaks the private attribute name into OpenLineage include_full_task_info events. The property change has not shipped in a provider release yet, so renaming the dict to a public hitl_summary_extra establishes the replacement contract while it is still free of any compatibility cost.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #70345
Human Summary
I had some concerns regarding
_hitl_summary_extrabeing a private dictionary after I merged the above.As the docs state that subclasses can extend HITLOperator, it should function better as a public attribute.
AI Summary
#70345 turned
hitl_summaryinto a computed property (so templatedsubject/bodyare read after rendering) and moved runtime/subclass additions into a private_hitl_summary_extradict. That leftHITLOperatorsubclasses without a supported way to extend the summary — the pattern the old attribute explicitly documented ("subclasses can extend it") now silently mutates a throwaway snapshot — and it leaks the private attribute name into OpenLineageinclude_full_task_infoevents (which serialize the operator's__dict__, where a property never appears).This renames the dict to a public
hitl_summary_extraand documents the contract on the property: each access builds a fresh snapshot, mutation of the returned dict has no effect, and extensions go throughhitl_summary_extra. Since #70345 has not shipped in a provider release yet, the rename is free of compatibility cost — waiting until after the next provider wave would turn it into a real break.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines