UI: Hide "run with latest bundle version" clear option for non-versioned bundles#70390
Draft
MannXo wants to merge 1 commit into
Draft
UI: Hide "run with latest bundle version" clear option for non-versioned bundles#70390MannXo wants to merge 1 commit into
MannXo wants to merge 1 commit into
Conversation
…ned bundles When clearing a Dag run, the option was shown whenever the run and latest Dag versions differed. For bundles that do not support versioning (e.g. LocalDagBundle) the run is never pinned to a bundle version and always resolves to the latest serialized Dag, so the option had no effect. Gate its visibility on the run actually being pinned to a bundle version so it appears only where it changes the outcome.
MannXo
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
July 24, 2026 13:29
MannXo
marked this pull request as draft
July 24, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clearing a Dag run, the "run with latest bundle version" checkbox was shown whenever the run's Dag version differed from the latest. For bundles that do not support versioning (e.g. LocalDagBundle) the run's
bundle_versionis always null and the serialized Dag resolved at run time is always the latest, so the checkbox offered a choice that had no effect.The checkbox now also requires the run to be pinned to a specific bundle version, so it appears only for versioning-capable bundles (e.g. GitDagBundle) where toggling it actually changes the outcome. The visibility logic is extracted into a small pure helper with unit tests, mirroring the existing
TaskInstance/runOnLatestVersion.ts.closes: #70371
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines