Remove no-op ServerResponseError re-raise blocks in airflowctl operations#70376
Open
Lee-W wants to merge 1 commit into
Open
Remove no-op ServerResponseError re-raise blocks in airflowctl operations#70376Lee-W wants to merge 1 commit into
Lee-W wants to merge 1 commit into
Conversation
…ions Every operation wrapped its request in a try/except that caught ServerResponseError only to re-raise it unchanged. The error is already raised by the client's raise_on_4xx_5xx response hook, so these wrappers added no behavior and only obscured the request logic. Dropping them leaves the propagation semantics identical while making each operation a plain request/parse.
Lee-W
requested review from
bugraoz93,
dheerajturaga,
henry3260 and
potiuk
as code owners
July 24, 2026 10:01
FrankYang0529
approved these changes
Jul 24, 2026
henry3260
approved these changes
Jul 24, 2026
henry3260
left a comment
henry3260
left a comment
Contributor
There was a problem hiding this comment.
LGTM, I left a few suggestions to make the Dag wording consistent
| return asset_id | ||
|
|
||
| def delete_dag_queued_events(self, dag_id: str, before: str) -> str | ServerResponseError: | ||
| """Delete a queued event for a dag.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Delete a queued event for a dag.""" | |
| """Delete a queued event for a Dag.""" |
| return dag_id | ||
|
|
||
| def delete_queued_event(self, dag_id: str, asset_id: str) -> str | ServerResponseError: | ||
| """Delete a queued event for a dag.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Delete a queued event for a dag.""" | |
| """Delete a queued event for a Dag.""" |
| return DAGDetailsResponse.model_validate_json(self.response.content) | ||
|
|
||
| def get_tags(self) -> DAGTagCollectionResponse | ServerResponseError: | ||
| """Get all DAG tags.""" |
Contributor
There was a problem hiding this comment.
Suggested change
| """Get all DAG tags.""" | |
| """Get all Dag tags.""" |
shahar1
approved these changes
Jul 24, 2026
Contributor
|
I think there might be a couple of pre-existing endpoint bugs here (unrelated to this PR’s cleanup, but worth flagging while we’re looking):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every operation wrapped its request in a try/except that caught
ServerResponseErroronly to re-raise it unchanged. The error is already raised by the client's raise_on_4xx_5xx response hook, so these wrappers added no behavior and only obscured the request logic.During reviewing #69397, I found out we have lots of such usage.
What
Dropping them leaves the propagation semantics identical while making each operation a plain request/parse.
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.