Fix BashOperator script detection after templating#70369
Open
fat-catTW wants to merge 1 commit into
Open
Conversation
fat-catTW
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
July 24, 2026 09:01
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
from
July 24, 2026 12:51
5af49a2 to
7bcc585
Compare
BashOperator template fields are rendered after construction, so script detection based on the raw constructor argument can choose the wrong execution path for templated commands.
fat-catTW
force-pushed
the
fix-bashoperator-template-init-70296
branch
from
July 24, 2026 12:55
7bcc585 to
6a4d28a
Compare
shahar1
reviewed
Jul 24, 2026
shahar1
left a comment
Contributor
There was a problem hiding this comment.
Static checks currently fail
Contributor
Author
|
I'll fix it. Thanks for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
BashOperatorso inline/script command detection runs afterbash_commandhas been templated.This avoids choosing the wrong execution path when
bash_commandis a Jinja expression that renders to a.shor.bashscript name.related: #70296
Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.