Skip to content

Fix OracleToOracleOperator source_sql_params default before rendering#70350

Open
baha-bouali wants to merge 3 commits into
apache:mainfrom
baha-bouali:fix/oracle-to-oracle-template-field-init
Open

Fix OracleToOracleOperator source_sql_params default before rendering#70350
baha-bouali wants to merge 3 commits into
apache:mainfrom
baha-bouali:fix/oracle-to-oracle-template-field-init

Conversation

@baha-bouali

Copy link
Copy Markdown

Fixes the oracle provider's entry from the #70296 exemption-list burn-down: OracleToOracleOperator applied a default-value coercion to a template field inside __init__, before Jinja templating runs.

  • OracleToOracleOperator: source_sql_params was defaulted from None to {} in __init__, against the raw un-rendered value. Moved the default to execute().

__init__ now only does a plain assignment; the field-dependent logic runs in execute(), after templating.
Test added covering the fixed behavior.
Related to #70296


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude (Sonnet) following the guidelines

@boring-cyborg

boring-cyborg Bot commented Jul 24, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@shahar1 shahar1 removed the backport-to-v3-3-test Backport to v3-3-test label Jul 24, 2026
Comment on lines +59 to +60
# if source_sql_params is None:
# source_sql_params = {}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove the comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants