Validate KubernetesResourceBaseOperator yaml_conf after rendering#70337
Merged
Conversation
yaml_conf and yaml_conf_file are template fields, rendered after __init__ runs. The base constructor raised when neither was set, acting on the un-rendered values. Move the presence check into a helper called from execute() in both the create and delete operators, so it runs after rendering. related: apache#70296 Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
hussein-awala,
jason810496,
jedcunningham,
jscheffl and
potiuk
as code owners
July 23, 2026 21:53
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-3-test
1fanwang
marked this pull request as draft
July 24, 2026 05:47
Signed-off-by: 1fanwang <1fannnw@gmail.com>
1fanwang
marked this pull request as ready for review
July 24, 2026 06:23
shahar1
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yaml_confandyaml_conf_fileare template fields, so they are rendered after__init__runs. The base constructor raisedAirflowExceptionwhen neither was set — a check against the un-rendered values. Move it into a_validate_yaml_conf()helper called fromexecute()in both the create and delete operators, so the presence check runs after rendering.related: #70296
Testing Done
New
test_missing_yaml_conf_rejected_at_executeconstructs both operators with neither field and asserts theAirflowExceptionnow surfaces fromexecute(). It fails on the pre-fix source (the constructor raises first) and passes after.test_resource.py: 12 passed.validate_operators_init.pyon the module exits 0; theraise AirflowExceptioncount is unchanged.Was generative AI tooling used to co-author this PR?
Generated-by: GitHub Copilot CLI following the guidelines