Skip to content

Apply Dag processor-specific labels to its Deployment metadata #70221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vtino17 wants to merge 2 commits into from
+26 −2
Closed

Apply Dag processor-specific labels to its Deployment metadata #70221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e0864
Apply Dag processor-specific labels to its Deployment metadata
vtino17 Jul 22, 2026
8795cda
Merge branch 'main' into fix/dag-processor-labels
vtino17 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions chart/newsfragments/53190.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Apply Dag processor-specific labels to its Deployment.
4 changes: 2 additions & 2 deletions chart/templates/dag-processor/dag-processor-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ metadata:
release: {{ .Release.Name }}
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
heritage: {{ .Release.Service }}
{{- with .Values.labels }}
{{- toYaml . | nindent 4 }}
{{- if or .Values.labels .Values.dagProcessor.labels }}
{{- mustMerge .Values.dagProcessor.labels .Values.labels | toYaml | nindent 4 }}
{{- end }}
{{- if .Values.dagProcessor.annotations }}
annotations: {{- toYaml .Values.dagProcessor.annotations | nindent 4 }}
Expand Down
23 changes: 23 additions & 0 deletions chart/tests/helm_tests/dagprocessor/test_labels_deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,29 @@ def test_should_add_component_specific_labels(self):
== "test_component_label_value"
)

def test_should_merge_global_and_component_specific_labels_in_deployment_metadata(self):
"""Test metadata.labels merge both global and component labels."""
docs = render_chart(
values={
"labels": {
"test_global_label": "test_global_label_value",
"common_label": "global_value",
},
"dagProcessor": {
"labels": {
"test_component_label": "test_component_label_value",
"common_label": "component_value",
},
},
},
show_only=[self.TEMPLATE_FILE],
)

labels = jmespath.search("metadata.labels", docs[0])
assert labels["test_global_label"] == "test_global_label_value"
assert labels["test_component_label"] == "test_component_label_value"
assert labels["common_label"] == "component_value"

def test_should_merge_global_and_component_specific_labels(self):
"""Test adding both .Values.labels and .Values.dagProcessor.labels."""
docs = render_chart(
Expand Down