Fix stale conn-id fallback assertion for cloudwatch remote logging#70210
Merged
Conversation
Provider dispatch (added for cloudwatch in apache#69816) intentionally drops the hook's default_conn_name fallback, so an unset remote_log_conn_id no longer resolves to aws_default. test_remote_logging_conn's no-conn-id case expected the old fallback and failed on main; update it to expect no connection env var.
jason810496
approved these changes
Jul 22, 2026
Member
There was a problem hiding this comment.
The PR (#69816) didn't trigger the task-sdk tests back then. I just came across the same CI failure a few seconds ago. Thanks for fixing this! (Just about to fix this and you raise the PR!)
Member
Author
|
yep, my pr encountered this issue haha. let's see how CI goes this time |
guan404ming
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provider dispatch (added for cloudwatch in #69816) intentionally drops the hook's default_conn_name fallback, so an unset remote_log_conn_id no longer resolves to aws_default. test_remote_logging_conn's no-conn-id case expected the old fallback and failed on main; update it to expect no connection env var.
Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.