-
Notifications
You must be signed in to change notification settings - Fork 17.4k
Add date and value filters to Backfills UI API #70151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Phinhas214
wants to merge
3
commits into
apache:main
Choose a base branch
from
Phinhas214:backfills-ui-filters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,6 +16,7 @@ | |
| # under the License. | ||
| from __future__ import annotations | ||
|
|
||
| import logging | ||
| from typing import Annotated | ||
|
|
||
| from fastapi import Depends, status | ||
|
|
@@ -28,8 +29,11 @@ | |
| FilterParam, | ||
| QueryLimit, | ||
| QueryOffset, | ||
| RangeFilter, | ||
| SortParam, | ||
| datetime_range_filter_factory, | ||
| filter_param_factory, | ||
| float_range_filter_factory, | ||
| ) | ||
| from airflow.api_fastapi.common.router import AirflowRouter | ||
| from airflow.api_fastapi.core_api.datamodels.backfills import BackfillCollectionResponse, BackfillResponse | ||
|
|
@@ -39,6 +43,8 @@ | |
| from airflow.api_fastapi.core_api.security import ReadableBackfillsFilterDep, requires_access_backfill | ||
| from airflow.models.backfill import Backfill | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| backfills_router = AirflowRouter(tags=["Backfill"], prefix="/backfills") | ||
|
|
||
|
|
||
|
|
@@ -52,6 +58,14 @@ | |
| def list_backfills_ui( | ||
| limit: QueryLimit, | ||
| offset: QueryOffset, | ||
| start_date_range: Annotated[RangeFilter, Depends(datetime_range_filter_factory("from_date", Backfill))], | ||
| end_date_range: Annotated[RangeFilter, Depends(datetime_range_filter_factory("to_date", Backfill))], | ||
| created_at: Annotated[RangeFilter, Depends(datetime_range_filter_factory("created_at", Backfill))], | ||
| completed_at: Annotated[RangeFilter, Depends(datetime_range_filter_factory("completed_at", Backfill))], | ||
| max_active_runs: Annotated[RangeFilter, Depends(float_range_filter_factory("max_active_runs", Backfill))], | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| reprocess_behavior: Annotated[ | ||
| FilterParam, Depends(filter_param_factory(Backfill.reprocess_behavior, str | None)) | ||
| ], | ||
| order_by: Annotated[ | ||
| SortParam, | ||
| Depends(SortParam(["id"], Backfill).dynamic_depends()), | ||
|
|
@@ -66,7 +80,17 @@ def list_backfills_ui( | |
| ) -> BackfillCollectionResponse: | ||
| select_stmt, total_entries = paginated_select( | ||
| statement=select(Backfill).options(joinedload(Backfill.dag_model)), | ||
| filters=[dag_id, active, readable_backfills_filter], | ||
| filters=[ | ||
| dag_id, | ||
| active, | ||
| readable_backfills_filter, | ||
| start_date_range, | ||
| end_date_range, | ||
| created_at, | ||
| completed_at, | ||
| max_active_runs, | ||
| reprocess_behavior, | ||
| ], | ||
| order_by=order_by, | ||
| offset=offset, | ||
| limit=limit, | ||
|
|
@@ -76,6 +100,7 @@ def list_backfills_ui( | |
| BackfillResponse(**row._mapping) if not isinstance(row, Backfill) else row | ||
| for row in session.scalars(select_stmt) | ||
| ] | ||
| log.warning("inside backfill*******************************************") | ||
| return BackfillCollectionResponse( | ||
| backfills=backfills, | ||
| total_entries=total_entries, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
start_date/end_dateare exposed as public filter names, butBackfillhas no columnswith those literal names. The underlying columns are
from_date/to_date.datetime_range_filter_factory'sattribute_nameargument to map the public-facing name tothe real column, so the API surface matches what
DagRunalready exposes without renamingBackfill's columns.