Buffer TS SDK logger output until the log socket connects#70085
Merged
Conversation
guan404ming
force-pushed
the
ts-log-preconnect-buffer
branch
from
July 19, 2026 07:33
76a0b65 to
ded4dd3
Compare
guan404ming
marked this pull request as ready for review
July 19, 2026 07:41
jason810496
reviewed
Jul 23, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Here're some nits caught by CC. LGTM overall, thanks!
Records emitted between subprocess start and the --logs socket connecting were silently dropped; the Go and Java SDKs already buffer this window and flush once connected.
Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
guan404ming
force-pushed
the
ts-log-preconnect-buffer
branch
from
July 23, 2026 12:21
6a28a82 to
5ed85dd
Compare
jason810496
approved these changes
Jul 23, 2026
jason810496
left a comment
jason810496
left a comment
Member
There was a problem hiding this comment.
Nice! Thank you for addressing all the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related
closes: #70077
related: #69302 (stacked on its branch; only the last commit is new)
Why
Log records emitted between subprocess start and the log socket connecting were silently dropped; the Go and Java SDKs already keep these early records.
How
LogChannelstart unconnected and buffer records untilconnect()flushes them to the socket in orderclose()if the socket never connectedWas generative AI tooling used to co-author this PR?