Skip to content

Prevent negative trigger queue delay metrics #69971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahar1 merged 2 commits into from
Jul 18, 2026
Merged

Prevent negative trigger queue delay metrics #69971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cec28d9
Prevent negative trigger queue delay metrics
viiccwen Jul 16, 2026
ec37fcf
Document trigger queue delay clock assumption
viiccwen Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions airflow-core/src/airflow/jobs/triggerer_job_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,7 @@ def update_triggers(self, requested_trigger_ids: set[int]):
if new_trigger_ids:
workloads_to_create = self.build_trigger_workloads(new_trigger_ids)

queued_at = time.time()
queued_at = time.monotonic()

for workload in workloads_to_create:
workload.queued_at = queued_at
Expand Down Expand Up @@ -1401,9 +1401,11 @@ async def create_triggers(self):
inlets=[Asset(name=name, uri=uri) for name, uri in workload.watched_assets.items()]
)
if workload.queued_at is not None:
# `queued_at` is captured by the supervisor process and consumed by the runner process.
# Both run on the same host, so their monotonic timestamps are comparable.
stats.timing(
"triggerer.trigger_queue_delay",
Comment thread
viiccwen marked this conversation as resolved.
int((time.time() - workload.queued_at) * 1000),
int((time.monotonic() - workload.queued_at) * 1000),
tags=prune_dict({"team_name": self.team_name}),
)

Expand Down
10 changes: 7 additions & 3 deletions airflow-core/tests/unit/jobs/test_triggerer_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,9 +1582,9 @@ async def test_create_triggers_emits_queue_delay_metric(
runner.team_name = team_name
runner.to_create.append(workload)

with patch(
"airflow.jobs.triggerer_job_runner.time.time",
return_value=101.5,
with (
patch("airflow.jobs.triggerer_job_runner.time.monotonic", return_value=101.5),
patch("airflow.jobs.triggerer_job_runner.time.time", return_value=90.0),
):
await runner.create_triggers()

Expand Down Expand Up @@ -2291,6 +2291,8 @@ def test_update_triggers_delegates_workload_creation(supervisor_builder, mocker)
supervisor = supervisor_builder()
supervisor.running_triggers = {1, 3}
workload = workloads.RunTrigger(id=2, classpath="some.trigger", encrypted_kwargs="", ti=None)
monotonic = mocker.patch("airflow.jobs.triggerer_job_runner.time.monotonic", return_value=100.0)
mocker.patch("airflow.jobs.triggerer_job_runner.time.time", return_value=90.0)
build_trigger_workloads = mocker.patch.object(
TriggerRunnerSupervisor, "build_trigger_workloads", autospec=True, return_value=[workload]
)
Expand All @@ -2299,6 +2301,8 @@ def test_update_triggers_delegates_workload_creation(supervisor_builder, mocker)

build_trigger_workloads.assert_called_once_with(supervisor, {2})
assert list(supervisor.creating_triggers) == [workload]
assert workload.queued_at == 100.0
monotonic.assert_called_once_with()
assert supervisor.cancelling_triggers == {1}


Expand Down