Add option to expose git-sync metrics port#69703
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
ca7265a to
913655a
Compare
|
Friendly ping. happy to rebase or adjust if needed. Thanks! |
Miretpl
left a comment
There was a problem hiding this comment.
GitSync itself will be removed in Helm Chart 2.0 as its functionality is replaced by GitDagBundle. Could you change the target branch to chart/v1-2-test, as it is a branch for 1.2x line releases?
Feel free to ping us if a quite high number of days will pass without any interaction from the maintainers on the PR. We all are spending our free time here, and some PRs may spend some time waiting for any maintainer's free moment to look at. Personally, I think that some ping after around 2 weeks without any feedback it ok-ish |
913655a to
80a86b7
Compare
80a86b7 to
6ba0122
Compare
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
The git-sync sidecar can serve Prometheus metrics via its built-in HTTP server
(
GITSYNC_HTTP_METRICS), but the chart provides no way to declare that port onthe container, so the metrics endpoint cannot be discovered or scraped.
This PR adds a
dags.gitSync.metrics.enabledoption (defaultfalse). Whenenabled, the git-sync sidecar container gets:
GIT_SYNC_HTTP_METRICS/GITSYNC_HTTP_METRICSenv vars set to"true"gitsync-metricsbound to the existingdags.gitSync.httpPortvalue, so the declared port can never drift from thebind address
The init container is unaffected (it runs no HTTP server). With the option
disabled (default), rendered manifests are identical to
main.Rendered output with
dags.gitSync.metrics.enabled=true:With default values, no ports section or metrics env vars are rendered
(verified via
helm templatebefore/after comparison).Exposing the metrics via a dedicated Service or scrape annotations is
intentionally left out of scope, per the open design question on the issue —
happy to add it here or in a follow-up based on maintainer preference.
Unit tests added in
test_git_sync_scheduler.pycovering: port + env renderingwhen enabled, port following a custom
httpPort, and no rendering by default.closes: #62592
Was generative AI tooling used to co-author this PR?
Claude Fable 5
Generated-by: [Claude Fable 5] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.