Fix Grid view scrollbar hiding latest Dags run#69693
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
bbovenzi
left a comment
There was a problem hiding this comment.
Looks like some of the task states of the grid are appearing above the run bars when scrolling. (Scroll down and then look at the top of the grid view). Let's make sure we are properly hiding content that we have scrolled past.
The sticky header's background only spanned the scrollport, so run columns beyond it had no backing and task cells showed through when the details panel was narrow and the grid scrolled right. The header's top padding also left a band the sticky task name column did not cover, exposing the tallest duration bar behind it.
a794bbb to
9fd6fc0
Compare
|
@bbovenzi Thanks for digging into this!! The sticky header is a width: auto block, so inside the scroll container it only spans the scroll-port. Run columns past that width had no header background behind them, and cells scrolling underneath were visible through the gap. Stretching the header with min-width: max-content makes its background cover the full scrollable width. While verifying I found a second gap, the header's top padding left a 16px band that the sticky task name column didn't cover, so the tallest duration bar (the only one that reaches the full BAR_HEIGHT, overflowing its wrapper by 2px) peeked out above the column when it scrolled behind it. Moving that padding from the header onto its children lets the column's background span the full header height. Verified in Safari, Firefox, and Chrome: narrow panel scrolled fully right and down, wide panel with header/body columns still aligned, and Gantt view unchanged. Rebased onto current main, which includes #69917 touching the same component. Bug reproduced
Bug Fix [Chrome. Firefox, Safari]
BUGFIX.VIDEO.movDrafted-by: Claude; reviewed by @MhussainD4772. |





On macOS, the vertical scrollbar in the Dags Grid view could overlay the task cells of the latest (rightmost) Dags run, making them hard to see and click. macOS uses overlay scrollbars, which do not respect scrollbar-gutter, so this code change adds a small non-interactive spacer after the newest run column in Grid-only view to keep the scrollbar off those cells.
closes: #69447
Testing
-Bug fix scrrenshots and videos are below



BUG-FIXED-VIDEO-.firefox.mov
BUG-FIXED-VIDEO.safari.mov
Before/after screenshots attached below.
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor following the guidelines