Add subject support for Google Workspace Domain-Wide Delegation#69687
Open
DEEPIKA-217M wants to merge 9 commits into
Open
Add subject support for Google Workspace Domain-Wide Delegation#69687DEEPIKA-217M wants to merge 9 commits into
subject support for Google Workspace Domain-Wide Delegation#69687DEEPIKA-217M wants to merge 9 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
potiuk
marked this pull request as draft
July 18, 2026 15:47
DEEPIKA-217M
marked this pull request as ready for review
July 19, 2026 11:58
aaron-y-chen
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Here is my feedback:
- Could you add unit tests covering
subject, including the case where it is combined withimpersonation_chain? - Have you tested this against a real Google Workspace / GCP environment? In my experience, credential-related changes, especially Domain-Wide Delegation, are hard to fully verify by relying only on unit tests or mocks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Google Workspace Domain-Wide Delegation by introducing a
subjectparameter across the Google provider authentication flow.Changes made
subjectsupport toGoogleBaseHook.subjectthrough the credentials provider.credentials.with_subject(...)when supported.subjectsupport to Google Drive, Google Sheets, and Discovery API hooks.subjectparameter.Testing
git diff --checkwith no formatting issues.Related: #67051
Generated-by: chatgpt for some reference
Important
🛠️ Maintainer triage note for @DEEPIKA-217M · by
@potiuk· 2026-07-18 15:46 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
See the Pull Request quality criteria for details.
The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.