Consolidate OpenLineage e2e tests into airflow-e2e-tests#69671
Merged
jason810496 merged 5 commits intoJul 11, 2026
Conversation
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
July 9, 2026 19:58
boring-cyborg
Bot
added
area:dev-tools
area:production-image
Member
|
Member
|
Love it !!!! |
Contributor
Author
The credit goes to @jason810496 for the idea :) |
Member
|
ALMOST ! |
Member
Thanks Shahar for consolidating this! |
jason810496
approved these changes
Jul 10, 2026
shahar1
force-pushed
the
consolidate-openlineage-e2e-tests
branch
from
July 10, 2026 04:32
87dec0a to
5844acb
Compare
Contributor
Author
|
CC: @kacpermuda |
kacpermuda
reviewed
Jul 10, 2026
kacpermuda
reviewed
Jul 10, 2026
kacpermuda
left a comment
kacpermuda
left a comment
Collaborator
There was a problem hiding this comment.
Two more comments, in general a very nice cleanup PR moving these tests to a common structure. Thanks for doing it !
The OpenLineage provider e2e suite was introduced as a standalone `providers-e2e-tests/` framework with its own docker-compose stack, harness, Dockerfile, breeze command and CI workflow. Review feedback on the introducing PR pointed out that `airflow-e2e-tests/` already hosts deployed-stack suites for providers (Elasticsearch/OpenSearch remote logging, Kafka event-driven), so a second parallel framework duplicates setup that already exists. Fold OpenLineage in as an `openlineage` E2E test mode: it reuses the shared docker-compose base, the testcontainers conftest, and the `AirflowClient`, adding only an overlay for the OpenLineage env config and a small runner that drives the provider's system-test DAGs. The separate framework, its breeze command, workspace member and dedicated workflow are removed; the older-Airflow compatibility matrix is dropped along with them.
The repo root was computed with an off-by-one parents index, so the system-test DAGs source resolved outside the repository and the e2e session failed at startup in CI. Reuse AIRFLOW_ROOT_PATH from the e2e framework constants instead of re-deriving it. Generated-by: Claude Code (Fable 5)
The shared AirflowClient parsed every response body as JSON, but the variable-deletion cleanup in the OpenLineage e2e harness issues DELETE requests that return 204 No Content, whose empty body is not valid JSON.
Review feedback on the consolidation asked to keep the compatibility coverage that ran the OpenLineage suite against older released Airflow versions with current provider code — it catches core-vs-provider breakages early, which matters for a provider as tightly coupled to core as OpenLineage. To keep PR CI cheap, the compat matrix now runs on canary (scheduled / main) only; PRs still run the PROD-image job. Also restores the suite's README next to the tests for debugging reference.
shahar1
force-pushed
the
consolidate-openlineage-e2e-tests
branch
from
July 10, 2026 14:20
5ac6613 to
65b671d
Compare
…label The compat matrix was gated to canary-only, giving no way to exercise it on a PR for a larger OpenLineage change. Add a dedicated run-openlineage-e2e-compat-tests selective-check output (canary or the explicit 'full tests needed' label) so maintainers can opt a PR in, while keeping it off ordinary OpenLineage PRs. Deliberately not tied to derived full_tests_needed, matching the run-ui-e2e-tests convention.
kacpermuda
approved these changes
Jul 10, 2026
kacpermuda
left a comment
kacpermuda
left a comment
Collaborator
There was a problem hiding this comment.
All looks good, thanks for cleaning it up.
Contributor
Backport failed to create: v3-3-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 37783b8 v3-3-testThis should apply the commit to the v3-3-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
This was referenced Jul 11, 2026
joshuabvarghese
pushed a commit
to joshuabvarghese/airflow
that referenced
this pull request
Jul 16, 2026
* Consolidate OpenLineage e2e tests into airflow-e2e-tests The OpenLineage provider e2e suite was introduced as a standalone `providers-e2e-tests/` framework with its own docker-compose stack, harness, Dockerfile, breeze command and CI workflow. Review feedback on the introducing PR pointed out that `airflow-e2e-tests/` already hosts deployed-stack suites for providers (Elasticsearch/OpenSearch remote logging, Kafka event-driven), so a second parallel framework duplicates setup that already exists. Fold OpenLineage in as an `openlineage` E2E test mode: it reuses the shared docker-compose base, the testcontainers conftest, and the `AirflowClient`, adding only an overlay for the OpenLineage env config and a small runner that drives the provider's system-test DAGs. The separate framework, its breeze command, workspace member and dedicated workflow are removed; the older-Airflow compatibility matrix is dropped along with them. * Fix OpenLineage e2e system-tests path resolution The repo root was computed with an off-by-one parents index, so the system-test DAGs source resolved outside the repository and the e2e session failed at startup in CI. Reuse AIRFLOW_ROOT_PATH from the e2e framework constants instead of re-deriving it. Generated-by: Claude Code (Fable 5) * Fix OpenLineage e2e crash on 204 responses from variable deletion The shared AirflowClient parsed every response body as JSON, but the variable-deletion cleanup in the OpenLineage e2e harness issues DELETE requests that return 204 No Content, whose empty body is not valid JSON. * Restore OpenLineage e2e older-Airflow compat matrix and README Review feedback on the consolidation asked to keep the compatibility coverage that ran the OpenLineage suite against older released Airflow versions with current provider code — it catches core-vs-provider breakages early, which matters for a provider as tightly coupled to core as OpenLineage. To keep PR CI cheap, the compat matrix now runs on canary (scheduled / main) only; PRs still run the PROD-image job. Also restores the suite's README next to the tests for debugging reference. * Allow triggering OpenLineage e2e compat matrix via full-tests-needed label The compat matrix was gated to canary-only, giving no way to exercise it on a PR for a larger OpenLineage change. Add a dedicated run-openlineage-e2e-compat-tests selective-check output (canary or the explicit 'full tests needed' label) so maintainers can opt a PR in, while keeping it off ordinary OpenLineage PRs. Deliberately not tied to derived full_tests_needed, matching the run-ui-e2e-tests convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following review feedback on #69212, the OpenLineage provider e2e tests are consolidated into the existing
airflow-e2e-tests/framework instead of the standaloneproviders-e2e-tests/framework introduced there.airflow-e2e-tests/already hosts deployed-stack suites for providers (Elasticsearch/OpenSearch remote logging, Kafka event-driven), so the separate framework duplicated setup that already exists. OpenLineage now runs as anopenlineage--e2e-test-mode: it reuses the shared docker-compose base, the testcontainers conftest, and the sharedAirflowClient, adding only a compose overlay for the OpenLineage env config and a small runner that drives the provider's system-test DAGs.The standalone
providers-e2e-tests/tree, itsbreeze testing providers-e2e-testscommand, its uv workspace member and its dedicated CI workflow are removed. The older-Airflow compatibility matrix (the only feature unique to that framework) is dropped along with it.related: #69212
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines