Skip to content

Align dynamic chain example with preceding static example#69550

Open
jonathankibg wants to merge 1 commit into
apache:mainfrom
jonathankibg:docs/align-dynamic-chain-example
Open

Align dynamic chain example with preceding static example#69550
jonathankibg wants to merge 1 commit into
apache:mainfrom
jonathankibg:docs/align-dynamic-chain-example

Conversation

@jonathankibg

@jonathankibg jonathankibg commented Jul 7, 2026

Copy link
Copy Markdown

This PR fixes a small inconsistency in the chain() documentation example.

The preceding example demonstrates:

chain(op1, op2, op3, op4)

which chains four tasks.

However, the equivalent dynamic example immediately below creates five tasks:

chain(*[EmptyOperator(task_id=f"op{i}") for i in range(1, 6)])

This change updates the range to create four operators instead, making both examples equivalent and easier to compare.

This is a documentation-only change and does not affect Airflow behavior.


Was generative AI tooling used to co-author this PR?
  • Yes (ChatGPT)

Important

🛠️ Maintainer triage note for @jonathankibg · by @potiuk · 2026-07-11 14:59 UTC

Helpful heads-up from the maintainers — please address before this PR can be reviewed (see our Pull Request quality criteria):

  • Pre-commit / static checks. See docs.

The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.

Automated triage — may be imperfect; a maintainer takes the next look.

@boring-cyborg

boring-cyborg Bot commented Jul 7, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@jonathankibg
jonathankibg force-pushed the docs/align-dynamic-chain-example branch 5 times, most recently from dc06d27 to eb10b9f Compare July 15, 2026 08:04
@jonathankibg

Copy link
Copy Markdown
Author

Fixed the pre-commit issue as requested. All checks look green except for CodeQL / Tests (AMD) / newsfragment check, which appear to be awaiting maintainer approval to run (standard for external contributors). Let me know if anything else is needed on my end.

@jonathankibg jonathankibg changed the title docs: align dynamic chain example with preceding static example Align dynamic chain example with preceding static example Jul 16, 2026
@jonathankibg
jonathankibg force-pushed the docs/align-dynamic-chain-example branch from eb10b9f to 9e15a2a Compare July 16, 2026 16:25
The dynamic example creates five operators whereas the preceding static example chains only four tasks. Update the range so both examples are consistent.
@jonathankibg
jonathankibg force-pushed the docs/align-dynamic-chain-example branch from 9e15a2a to 73752f4 Compare July 16, 2026 21:57
@jonathankibg

Copy link
Copy Markdown
Author

Renamed the PR title and commit message to follow the imperative-mode convention (removed the docs: conventional-commit prefix), as flagged by the CI check. Should be green now.

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:documentation ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants