Skip to content

Extract shared bundle metadata logic from coordinators#69296

Merged
jason810496 merged 1 commit into
apache:mainfrom
guan404ming:worktree-coordinator-shared-metadata
Jul 4, 2026
Merged

Extract shared bundle metadata logic from coordinators#69296
jason810496 merged 1 commit into
apache:mainfrom
guan404ming:worktree-coordinator-shared-metadata

Conversation

@guan404ming

Copy link
Copy Markdown
Member

Related Issue

closes #69291

Why

NodeCoordinator, ExecutableCoordinator, and JavaCoordinator each carried verbatim copies of metadata validation, schema-version parsing, and root-path conversion, agreed for extraction in #68548 review.

How

  • Add coordinators/_bundle_metadata.py with convert_roots, validate_schema_version, parse_metadata_mapping, extract_supervisor_schema_version, and ResolvedBundle
  • Replace the duplicated implementations in all three coordinators with imports of the shared helpers
  • Update one executable test asserting the now-unified metadata-rejection log event

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    Claude Code with Fable 5

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@guan404ming
guan404ming marked this pull request as ready for review July 3, 2026 06:56

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the consolidation.

@jason810496 jason810496 added the area:coordinator Coordinator: The interface to spawn Lang-SDK subprocesses label Jul 4, 2026
@jason810496 jason810496 added this to the Airflow 3.4.0 milestone Jul 4, 2026
@jason810496
jason810496 merged commit 7b24027 into apache:main Jul 4, 2026
200 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:coordinator Coordinator: The interface to spawn Lang-SDK subprocesses area:task-sdk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript SDK: refactor shared logic between NodeCoordinator and ExecutableCoordinator

2 participants