Skip to content

[AIP-94] airflowctl jobs: add check command#68534

Open
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:migrate-jobs-check-to-airflowctl
Open

[AIP-94] airflowctl jobs: add check command#68534
FrankYang0529 wants to merge 1 commit into
apache:mainfrom
FrankYang0529:migrate-jobs-check-to-airflowctl

Conversation

@FrankYang0529

@FrankYang0529 FrankYang0529 commented Jun 14, 2026

Copy link
Copy Markdown
Member
  • Add a airflowctl jobs check command on top of the existing jobs list operation.
  • Mark airflow jobs check with the maintainer-facing @deprecated_for_airflowctl("airflowctl jobs check") marker and register it in MIGRATED_CLI_COMMANDS.

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code with Opus 4.8] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@aaron-y-chen aaron-y-chen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, really nice :)

Comment thread airflow-ctl/src/airflowctl/ctl/commands/jobs_command.py Outdated
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from e3c0450 to 61ad837 Compare July 8, 2026 08:29

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit. mostly good

Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_jobs_command.py Outdated
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch 2 times, most recently from 244574a to 63b191e Compare July 24, 2026 02:44

@Lee-W Lee-W left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few parameterization nitpick. but overall looks good

Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_jobs_command.py Outdated
Comment thread airflow-ctl/tests/airflow_ctl/ctl/commands/test_jobs_command.py Outdated
airflowctl had no equivalent of airflow jobs check, so component health
could not be checked through the API from a remote machine. The
validation / alive-count / exit-code logic cannot be auto-generated from
a single operation method, so the command is handwritten on top of the
jobs list operation.

Per the marker-only direction in apache#68402, the airflow CLI counterpart
keeps its local DB implementation (it backs the docker-compose and Helm
liveness probes) and only gets the maintainer-facing migration marker:
no user-facing warning, no behavior change.

Signed-off-by: PoAn Yang <payang@apache.org>
@FrankYang0529
FrankYang0529 force-pushed the migrate-jobs-check-to-airflowctl branch from 63b191e to 865f1bf Compare July 24, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants