Extract shared request handler for GetXCom part#67090
Closed
xchwan wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Xch1 <qchwan@gmail.com>
Contributor
|
I think this is already handled in #65624 unless I am missing something? |
Contributor
Author
|
I’m aware of that PR, but I’m not sure whether it might be too large for other reviewers to spend time going through it thoroughly. Looking at the discussion, I haven’t seen much participation from reviewers besides you, so I tried splitting out one smaller part of the changes to see if it would be easier to get merged. If this approach works, it might be a good way to gradually move the issue forward. |
Contributor
|
That one has merged, if this is just a duplicate, then close it. |
ferruzzi
requested changes
May 21, 2026
Contributor
ferruzzi
left a comment
There was a problem hiding this comment.
blocking accidental merge
Contributor
Author
|
I saw it merged, i'll close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #65570
@ferruzzi
For your plan
Phase 1: High-overlap handlers (three or more supervisors share this logic)
GetXCom - Activity, Triggerer, DFP
PutVariable - Activity, Triggerer, DFP
DeleteVariable - Activity, Triggerer, DFP
GetTICount - Activity, Triggerer, DFP
GetTaskStates - Activity, Triggerer, DFP
GetPreviousTI - Activity, Triggerer, DFP
I modify GetXCom part. I think split to each part can be easy for review/test/troubleshoot
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.