Skip to content

Extract shared request handler for GetXCom part#67090

Closed
xchwan wants to merge 2 commits into
apache:mainfrom
xchwan:elif_GetXCom_extact_handler
Closed

Extract shared request handler for GetXCom part#67090
xchwan wants to merge 2 commits into
apache:mainfrom
xchwan:elif_GetXCom_extact_handler

Conversation

@xchwan
Copy link
Copy Markdown
Contributor

@xchwan xchwan commented May 18, 2026

related: #65570
@ferruzzi
For your plan
Phase 1: High-overlap handlers (three or more supervisors share this logic)
GetXCom - Activity, Triggerer, DFP
PutVariable - Activity, Triggerer, DFP
DeleteVariable - Activity, Triggerer, DFP
GetTICount - Activity, Triggerer, DFP
GetTaskStates - Activity, Triggerer, DFP
GetPreviousTI - Activity, Triggerer, DFP

I modify GetXCom part. I think split to each part can be easy for review/test/troubleshoot


Was generative AI tooling used to co-author this PR?
  • Yes (claude code Sonnet 4.6)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

Signed-off-by: Xch1 <qchwan@gmail.com>
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 18, 2026
@ferruzzi
Copy link
Copy Markdown
Contributor

I think this is already handled in #65624 unless I am missing something?

@xchwan
Copy link
Copy Markdown
Contributor Author

xchwan commented May 20, 2026

I’m aware of that PR, but I’m not sure whether it might be too large for other reviewers to spend time going through it thoroughly. Looking at the discussion, I haven’t seen much participation from reviewers besides you, so I tried splitting out one smaller part of the changes to see if it would be easier to get merged.

If this approach works, it might be a good way to gradually move the issue forward.

@ferruzzi
Copy link
Copy Markdown
Contributor

That one has merged, if this is just a duplicate, then close it.

Copy link
Copy Markdown
Contributor

@ferruzzi ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking accidental merge

@xchwan
Copy link
Copy Markdown
Contributor Author

xchwan commented May 21, 2026

I saw it merged, i'll close it.

@xchwan xchwan closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants