Skip to content

Chart: Make Git-Sync DAG mount path configurable#65758

Open
Subham-KRLX wants to merge 2 commits into
apache:chart/v1-2x-testfrom
Subham-KRLX:fix/chart-gitsync-link-configurable
Open

Chart: Make Git-Sync DAG mount path configurable#65758
Subham-KRLX wants to merge 2 commits into
apache:chart/v1-2x-testfrom
Subham-KRLX:fix/chart-gitsync-link-configurable

Conversation

@Subham-KRLX

@Subham-KRLX Subham-KRLX commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

This PR allows users to configure the Git Sync destination directory via dags.gitSync.link (defaulting to "repo" for backward compatibility).

What changed

  • Added dags.gitSync.link to values and schema.
  • Updated sidecar environment variables and the airflow_dags helper to honor the custom link name.
  • Updated documentation and release notes.

Why

Currently Git-Sync forces the DAG path to be /dags/repo/.... This fix enables customization for users who need a different directory structure.

closes: #65589


Was generative AI tooling used to co-author this PR?
  • Yes — Claude(for research)

@Subham-KRLX
Subham-KRLX marked this pull request as draft April 24, 2026 08:54
@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch from e77f87e to 636edbc Compare April 24, 2026 08:59
@Subham-KRLX
Subham-KRLX marked this pull request as ready for review April 24, 2026 09:00
@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch from 636edbc to 3c311e7 Compare April 24, 2026 09:06
@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch from 3c311e7 to 312e4a0 Compare April 24, 2026 09:08
@Subham-KRLX Subham-KRLX changed the title Fix/chart gitsync link configurable Chart: Make Git-Sync DAG mount path configurable Apr 24, 2026
@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch from 312e4a0 to 71f4dc6 Compare April 24, 2026 13:19
@Subham-KRLX
Subham-KRLX requested a review from dstandish as a code owner April 24, 2026 13:19
@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch 2 times, most recently from 65b408b to 2b09d4c Compare April 24, 2026 13:24
@jscheffl

Copy link
Copy Markdown
Contributor

I am not sure and following the bug ticket "why" thisis needed. In my view making this configurable adds un-needed complexity.

I would dis-like to merge additional complexity if there is no described need.

Side note: Plan mid-term is to remove gitsync completely from the chart and migrate to dag bundles. Adding new features to this inside the chart therefore is rather un-desired.

@mortazakiani as you opened the bug ticket asking for the feature, is there any rationale or convincing argument why this complexity should be added?

Comment thread chart/RELEASE_NOTES.rst

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking request changed to block accidental merge

@Subham-KRLX

Copy link
Copy Markdown
Contributor Author

I am not sure and following the bug ticket "why" thisis needed. In my view making this configurable adds un-needed complexity.

I would dis-like to merge additional complexity if there is no described need.

Side note: Plan mid-term is to remove gitsync completely from the chart and migrate to dag bundles. Adding new features to this inside the chart therefore is rather un-desired.

@mortazakiani as you opened the bug ticket asking for the feature, is there any rationale or convincing argument why this complexity should be added?

I am not sure and following the bug ticket "why" thisis needed. In my view making this configurable adds un-needed complexity.

I would dis-like to merge additional complexity if there is no described need.

Side note: Plan mid-term is to remove gitsync completely from the chart and migrate to dag bundles. Adding new features to this inside the chart therefore is rather un-desired.

@mortazakiani as you opened the bug ticket asking for the feature, is there any rationale or convincing argument why this complexity should be added?

@jscheffl the hardcoded "repo" directory breaks existing DAG setups when migrating to the Helm chart teams have to restructure their entire DAG paths just because of this hardcoded name I know git sync is being deprecated but users need this working now It's just one config option that defaults to current behavior.

@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch from 0426c7a to fe7e284 Compare April 25, 2026 03:24
@Subham-KRLX
Subham-KRLX changed the base branch from chart/v1-2x-test to chart/v1-2x-stable May 19, 2026 10:21
@Subham-KRLX
Subham-KRLX changed the base branch from chart/v1-2x-stable to chart/v1-2x-test May 19, 2026 10:22
@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch 2 times, most recently from 51c5bff to a1ce094 Compare May 19, 2026 10:29
@Subham-KRLX
Subham-KRLX requested a review from bugraoz93 May 19, 2026 10:30
@potiuk

potiuk commented May 24, 2026

Copy link
Copy Markdown
Member

@Subham-KRLX A few things need addressing before review — see our Pull Request quality criteria.

  • CI fails: CI image checks / Build documentation (--docs-only) (and possibly other checks — see the Checks tab for the full list).

No rush.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.


Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting

@Subham-KRLX
Subham-KRLX force-pushed the fix/chart-gitsync-link-configurable branch from a1ce094 to 5fffd3d Compare May 25, 2026 01:15
@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label May 26, 2026
@Subham-KRLX
Subham-KRLX requested a review from jscheffl June 7, 2026 11:40
@jscheffl

jscheffl commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

@Subham-KRLX you re-requested review by me, still I am +0. Some other maintainer need to review and merge.

@potiuk potiuk added ready for maintainer review Set after triaging when all criteria pass. and removed ready for maintainer review Set after triaging when all criteria pass. labels Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart kind:documentation ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

can not change mount point of dags when enabling git sync from/dags/repo

7 participants