Chart: Make Git-Sync DAG mount path configurable#65758
Conversation
e77f87e to
636edbc
Compare
636edbc to
3c311e7
Compare
3c311e7 to
312e4a0
Compare
312e4a0 to
71f4dc6
Compare
65b408b to
2b09d4c
Compare
|
I am not sure and following the bug ticket "why" thisis needed. In my view making this configurable adds un-needed complexity. I would dis-like to merge additional complexity if there is no described need. Side note: Plan mid-term is to remove gitsync completely from the chart and migrate to dag bundles. Adding new features to this inside the chart therefore is rather un-desired. @mortazakiani as you opened the bug ticket asking for the feature, is there any rationale or convincing argument why this complexity should be added? |
jscheffl
left a comment
There was a problem hiding this comment.
Marking request changed to block accidental merge
@jscheffl the hardcoded "repo" directory breaks existing DAG setups when migrating to the Helm chart teams have to restructure their entire DAG paths just because of this hardcoded name I know git sync is being deprecated but users need this working now It's just one config option that defaults to current behavior. |
0426c7a to
fe7e284
Compare
51c5bff to
a1ce094
Compare
|
@Subham-KRLX A few things need addressing before review — see our Pull Request quality criteria.
No rush. Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you. Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting |
a1ce094 to
5fffd3d
Compare
|
@Subham-KRLX you re-requested review by me, still I am +0. Some other maintainer need to review and merge. |
This PR allows users to configure the Git Sync destination directory via
dags.gitSync.link(defaulting to"repo"for backward compatibility).What changed
dags.gitSync.linkto values and schema.airflow_dagshelper to honor the custom link name.Why
Currently Git-Sync forces the DAG path to be
/dags/repo/.... This fix enables customization for users who need a different directory structure.closes: #65589
Was generative AI tooling used to co-author this PR?