Fixes strict aliasing violations#300
Merged
Merged
Conversation
Native 128-bit VSX implementations of the wavelet, colour, and codestream kernels and the HTJ2K block decoder, with runtime dispatch via hwcap. Supported targets are POWER9 (ISA 3.0) and newer, little-endian only; other PPC targets use the generic code paths. Beyond a straight port, the kernels use POWER-specific forms where measurement showed a win: xvrspi for round-to-nearest-away in the float-to-int conversions, vec_sel for masked selects, and a block decoder that destuffs the MagSgn bitstream upfront so per-quad bit consumption is a GPR add instead of a vector-window shift. The SIMD block decoder is dispatched everywhere on POWER10, and for irreversible tile components on POWER9, where it beats the scalar decoder; reversible content on POWER9 stays scalar, which is slightly faster there. Assisted-by: Lance Albertson <lance@osuosl.org> Assisted-by: Thushan Fernando <thushan@thushanfernando.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes strict aliasing violations, which lurk in the background and can cause failure in an unpredictable ways.