Skip to content

cm: launcher: "not enough resources" error should have higher priority - #572

Open
mykola-kobets-epam wants to merge 1 commit into
aosedge:feature_release_9.1from
mykola-kobets-epam:cm-launcher-error-ranking-3
Open

cm: launcher: "not enough resources" error should have higher priority#572
mykola-kobets-epam wants to merge 1 commit into
aosedge:feature_release_9.1from
mykola-kobets-epam:cm-launcher-error-ranking-3

Conversation

@mykola-kobets-epam

Copy link
Copy Markdown
Collaborator

There are two main error types in balancer:

  • not enough resources: CPU, RAM, max instance num
  • no matching node/runtime

There are two main error types in balancer:
- not enough resources: CPU, RAM, max instance num
- no matching node/runtime

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.05%. Comparing base (c38d1f6) to head (bf25ec6).

Files with missing lines Patch % Lines
src/core/cm/launcher/balancer.cpp 66.66% 8 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature_release_9.1     #572   +/-   ##
====================================================
  Coverage                85.04%   85.05%           
====================================================
  Files                      314      314           
  Lines                    28521    28525    +4     
  Branches                  3823     3824    +1     
====================================================
+ Hits                     24257    24262    +5     
+ Misses                    4264     4263    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
34.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud


private:
using NodeRuntimes = StaticMap<Node*, StaticArray<const RuntimeInfo*, cMaxNumNodeRuntimes>, cMaxNumInstances>;
enum class ScheduleDecision { eScheduled, eSkipManifest, eError };

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Aos enum to properly display it in log.
What does eSkipManifest mean?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants