Skip to content

cm: launcher: rank scheduling errors in balancer - #571

Open
mykola-kobets-epam wants to merge 1 commit into
aosedge:feature_release_9.1from
mykola-kobets-epam:cm-launcher-error-ranking
Open

cm: launcher: rank scheduling errors in balancer#571
mykola-kobets-epam wants to merge 1 commit into
aosedge:feature_release_9.1from
mykola-kobets-epam:cm-launcher-error-ranking

Conversation

@mykola-kobets-epam

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Mykola Kobets <mykola_kobets@epam.com>
@mykola-kobets-epam
mykola-kobets-epam force-pushed the cm-launcher-error-ranking branch from 65bc537 to ea56756 Compare May 21, 2026 07:58
@mykola-kobets-epam mykola-kobets-epam changed the title cm: launcher: rank scheduling errorss in balancer cm: launcher: rank scheduling errors in balancer May 21, 2026
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.63636% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.03%. Comparing base (c38d1f6) to head (ea56756).

Files with missing lines Patch % Lines
src/core/cm/launcher/balancer.cpp 53.57% 13 Missing ⚠️
src/core/cm/launcher/rankederror.hpp 81.25% 3 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature_release_9.1     #571      +/-   ##
=======================================================
- Coverage                85.04%   85.03%   -0.02%     
=======================================================
  Files                      314      315       +1     
  Lines                    28521    28544      +23     
  Branches                  3823     3825       +2     
=======================================================
+ Hits                     24257    24272      +15     
- Misses                    4264     4272       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
36.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

}

Error scheduleErr = ErrorEnum::eNotFound;
RankedError scheduleErr;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still do not understand why we need ranked error. Instance scheduling should fail on first error.
In our case, if there are different manifests for different arch. First we should check if there are nodes matches item arches. If not, return error - no suitable node architecture found. Then we try to schedule according to resource, if there are not enough resources available, return resource error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants