refactor: make, scripts. and fix error handling#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor to improve import organization, streamline build and deployment scripts, and update environment/configuration handling. The changes focus on using granular path aliases for imports, simplifying build commands and workflows, and aligning environment variables with standard Node conventions. Additionally, some minor improvements and cleanups are included.
Import organization and path alias refactor
Updated all internal imports to use granular path aliases (e.g.,
@config,@database,@mailer,@plugins,@repositories,@types,@utils) instead of the generic@libsalias. This improves clarity and maintainability across the codebase. (src/base.ts,src/bull/queue/send-mail-queue.ts,src/bull/worker/send-mail-worker.ts,src/index.ts,src/libs/cache/cache.ts,src/libs/config/app.config.ts,src/libs/database/postgres/index.ts,.github/copilot-instructions.md) [1] [2] [3] [4] [5] [6] [7] [8]Expanded and clarified import instructions in
.github/copilot-instructions.mdto document available path aliases and enforce a new grouping order for imports.Build, deployment, and workflow simplification
Simplified build and start scripts in
package.json,Makefile, andDockerfileby removing multi-service commands and focusing on a single server entrypoint. Removedconcurrentlydependency and related scripts. [1] [2] [3] [4] [5] [6] [7]Updated GitHub Actions workflow (
.github/workflows/build.yml) to use Bun-native commands for installing and running Drizzle migrations/generations, and removed unused Docker Compose steps. [1] [2] [3]Environment and configuration updates
NODE_ENVinstead ofAPP_ENVfor consistency with Node.js standards, updating.env.exampleandsrc/libs/config/app.config.ts. [1] [2]Minor improvements and cleanups
_, reducing unnecessary lint errors.