feat: surface SCM summaries in desktop#263
Open
whoisasx wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The backend SCM observer already persists PR, CI, review, and mergeability facts, and
/api/v1/sessionsderives session status from those facts. The desktop app was not reliably surfacing that state: it treated/eventsas the main live signal, gated PR detail fetches on mock-stylesession.pullRequestdata, and masked some backend statuses such asmerged.Scoped V1 behavior
GET /api/v1/sessionsand treats backendsession.statusas authoritative.GET /api/v1/eventsopen as an invalidation stream only.GET /api/v1/sessions/{sessionId}/pr.no_signal, preserves backendmergedeven for terminated rows, and uses a neutralunknownfallback for unrecognized status values.Backend changes
GET /api/v1/sessions/{sessionId}/prto returnSessionPRSummaryitems while leaving the PR claim response on the existing aggregateSessionPRFactsshape.backend/internal/httpd/apispec/openapi.yamlandfrontend/src/api/schema.ts.Frontend changes
useSessionScmSummary(sessionId)over the generatedSessionPRSummarytype.session.pullRequestdata and renders PR, CI, review, and mergeability sections.WorkspaceSession.pullRequest.no_signal,merged, unknown fallback, and the sidebar daemon readiness indicator (ready, notrunning).Intentional omissions / future work
conflictFilesremains empty unless real conflict-file facts exist later.Tests run
npm run apicd backend && go test ./internal/service/session ./internal/httpd/controllers ./internal/httpd/apispec/...npm run frontend:typechecknpm --prefix frontend run test -- src/renderer/types/workspace.test.ts src/renderer/hooks/useWorkspaceQuery.test.tsx src/renderer/lib/event-transport.test.ts src/renderer/components/Sidebar.test.tsx