feat(frontend): surface multiple PRs per session#237
Open
Pritom14 wants to merge 2 commits into
Open
Conversation
Replace the single optional pullRequest on a session with a prs[] list and render it across every PR surface: the inspector stacks one card per PR, the PR board lists one row per attributed PR, and the board card shows a PR count summary. useWorkspaceQuery now maps the live /api/v1/sessions prs[] into the query (the frontend surfaced no PRs before this). Ordering is actionable-first (open, draft, merged, closed). Adds unit tests (SessionInspector, PullRequestsPage), a Playwright e2e spec, and a multi-PR mock-data fixture.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #230 (the backend multi-PR-per-session work). Base this on
feat/multi-pr-per-session; retarget tomainonce #230 merges.Summary
The frontend modelled a session as owning at most one PR (
pullRequest?). The backend now attributes a list of PRs to a session (a stack, or several independent PRs), so this wiresprs: PullRequestFacts[]through every PR surface. NoteuseWorkspaceQuerynever mapped PRs at all before this, so the live app surfaced zero PRs regardless of backend state. This turns them on.Ordering everywhere is actionable-first: open, draft, merged, closed.
What changed
types/workspace.ts:PRState/PullRequestFactstypes andsortedPRs/openPRs/mergedPRCount/primaryPRhelpers.hooks/useWorkspaceQuery.ts: map the live/api/v1/sessionsprs[]into the query.components/SessionInspector.tsx: render a stack of single-PR cards (one card per PR with state badge, CI / merge / review facts, and an Open link), replacing the old single-PR fetch.components/PullRequestsPage.tsx: one row per attributed PR; merge / resolve act on each PR by its own number.components/SessionsBoard.tsx: card footer shows a PR count summary.SessionInspector,PullRequestsPage) and a Playwright e2e spec.User flow
session-branch/...namespace.Test plan
pnpm test(unit + functional) green, including the new inspector and PR-board testspnpm typecheckcleane2e/multi-pr.spec.ts) renders the inspector stack and the PR board from mock data