fix(sessions): remove agentRules spawn path#159
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
harshitsinghbhandari has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
harshitsinghbhandari
force-pushed
the
fix/remove-agent-rules-internals
branch
from
189fc8f to
255c50f
Compare
Contributor
There was a problem hiding this comment.
harshitsinghbhandari has reached the 50-review limit for trial accounts. To continue receiving code reviews, upgrade your plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agentRules/--rulespath from CLI, API DTOs, and session manager prompt assemblySpawnSessionRequest.agentRulesis no longer advertisedWhy
Persistent or ad-hoc project instructions should flow through the system prompt / repo-local
AGENTS.mdmodel rather than a separateagentRulesprompt-concatenation path.Tests
cd backend && go test ./internal/session_manager ./internal/httpd/controllers ./internal/httpd/apispec ./internal/clicd backend && go test ./...Notes
npm run apicould not complete locally because dependencies are not installed (openapi-typescriptmissing from local node_modules), so I regenerated the TS schema withnpx openapi-typescript@7.4.4 backend/internal/httpd/apispec/openapi.yaml -o frontend/src/api/schema.ts.aa-77is updating PR feat(config): persist per-project agent config and resolve it at spawn #154 to remove the new project-config rules fields and future-only config fields; I sent it conflict-avoidance notes for this branch.