Skip to content

refactor(configs): migrate compute configs to ComputeConfig schema#742

Merged
Aydin-ab merged 2 commits into
mainfrom
migrate-template-compute-configs
Jun 8, 2026
Merged

refactor(configs): migrate compute configs to ComputeConfig schema#742
Aydin-ab merged 2 commits into
mainfrom
migrate-template-compute-configs

Conversation

@Aydin-ab

@Aydin-ab Aydin-ab commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Migrates all 111 compute configs under configs/ from the legacy schema to the user-facing ComputeConfig schema; flips ci/validate_build_yaml.py to validate it.

Published bundles are unchanged — rayapp build converts to the legacy bundle format at publish time (ray-project/rayci#492, shipped in rayci v0.45.0, now pinned on main). Validated: converter audit 111/111; staging publishes tmpl-publish #367#369; release-binary smoke #371 (v0.45.0 → staging, clone path verified).

Comment thread ci/validate_build_yaml.py Outdated
Comment thread ci/validate_build_yaml.py Outdated
Aydin-ab added a commit that referenced this pull request Jun 3, 2026
Per review on #742: from the user perspective there is only one ComputeConfig schema.

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
@Aydin-ab Aydin-ab force-pushed the migrate-template-compute-configs branch from 7abed91 to eda5ebe Compare June 5, 2026 20:09
@Aydin-ab Aydin-ab marked this pull request as ready for review June 5, 2026 20:29
Aydin-ab added a commit that referenced this pull request Jun 5, 2026
configs/ now uses the new user-facing ComputeConfig schema (#742): rewrite the schema reference, flip the legacy warning in conventions, and simplify the create-template compute-config step (workspace config is now copied as-is, pruned of defaults).

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Aydin-ab added a commit that referenced this pull request Jun 5, 2026
Per review on #742: from the user perspective there is only one ComputeConfig schema.

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
@Aydin-ab Aydin-ab requested a review from elliot-barn June 5, 2026 20:36
@@ -1,11 +1,9 @@
head_node_type:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't used in the template right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, that's an orphan compute config folder. We can cleanup/declutter orphans later, i'm just removing any trace of the legacy schema in this PR

@elliot-barn elliot-barn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

Aydin-ab added 2 commits June 8, 2026 10:44
Migrate every compute config under configs/ from the legacy CreateComputeTemplateConfig schema to the new user-facing ComputeConfig schema (head_node/worker_nodes/min_nodes/max_nodes/market_type/enable_cross_zone_scaling), pruning defaults (min 0, ON_DEMAND, auto_select false, unschedulable-by-default head resources). Flip ci/validate_build_yaml.py to validate the new schema: strict top-level keys reject legacy configs, and auto_select_worker_config cannot be combined with worker_nodes (mirrors the SDK constraint).

Published bundles are unaffected: rayapp build converts new->legacy at publish time (ray-project/rayci#492), so the console clone path keeps receiving legacy configs.

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
There is only one ComputeConfig schema from the user perspective; rename New* models and reword comments/errors accordingly. Per review.

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
@Aydin-ab Aydin-ab force-pushed the migrate-template-compute-configs branch from eda5ebe to 8867057 Compare June 8, 2026 17:46
Aydin-ab added a commit that referenced this pull request Jun 8, 2026
configs/ now uses the new user-facing ComputeConfig schema (#742): rewrite the schema reference, flip the legacy warning in conventions, and simplify the create-template compute-config step (workspace config is now copied as-is, pruned of defaults).

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Aydin-ab added a commit that referenced this pull request Jun 8, 2026
Per review on #742: from the user perspective there is only one ComputeConfig schema.

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
@Aydin-ab Aydin-ab merged commit 62af2ed into main Jun 8, 2026
4 checks passed
@Aydin-ab Aydin-ab deleted the migrate-template-compute-configs branch June 8, 2026 19:06
Aydin-ab added a commit that referenced this pull request Jun 8, 2026
Documents the user-facing `ComputeConfig` schema as the `configs/`
convention: rewrites `schemas/compute-config-schema.yaml`, updates the
warning in `references/conventions.md`, and simplifies the
create-template compute-config step (workspace config is copied as-is,
pruned of defaults — no more schema translation).

Lands after #742.

---------

Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants