NOTEPOD: add test of new note creation #236#410
Open
Amoghhosamane wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@"
Pull Request Details
Description
This PR addresses issue #272 by replacing AES encryption of note content with
base64 encoding. Currently, note text is encrypted using the created time as an
AES key because rdflib cannot parse multiline text containing # (hash) values.
As suggested in #272, base64 encoding is a better alternative — it is simpler,
reversible, and still solves the rdflib parsing problem without the overhead or
security implications of encryption (since the "key" was just a timestamp anyway).
Changes:
lib/utils/encryption.dart:encryptVal()now encodes plaintext using base64.decryptVal()now decodes from base64, with a fallback to AES decryption forbackward compatibility with notes saved using the previous scheme.
Related Issues
Closes #272
Type of Change
How To Test?
display correctly (backward-compatible AES fallback).
Checklist
Finalising
"@