Add CTLabel support in the GetValue method for MatchField#88
Merged
antoninbas merged 1 commit intoAug 19, 2025
Conversation
hongliangl
approved these changes
Aug 15, 2025
wenyingd
reviewed
Aug 15, 2025
| if !m.HasMask { | ||
| return value | ||
| } | ||
| // TODO: we match the logic for the ByteArrayField case, but it's not clear why we |
There was a problem hiding this comment.
It is because the type of v.Data is byte[], while m.Mask type is util.Message, and we need to convert to byte[] to construct type DataWithMask.
Author
There was a problem hiding this comment.
m.Value and m.Mask are the same. The type is util.Message but that's an interface. The concrete type is *CTLabel for both, so we could just use m.Mask.(*CTLabel).Data[:] for the mask (which would not make a copy). If you think no copy is needed, I can replace MarshalBinary with that.
There was a problem hiding this comment.
Sounds good to me without additional copy.
Author
There was a problem hiding this comment.
I removed the unnecessary copies, please take another look
Also remove unnecessary copies when processing masks for other match field types. Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
antoninbas
force-pushed
the
add-support-for-ctlabel-when-getting-match-field-value
branch
from
68b9f64 to
8cd8643
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.