fix: skip home-based config paths when $HOME is not set#406
Merged
Conversation
When $HOME is not defined, os.UserHomeDir returns an error. Previously this caused readFxrc to return an error, which panicked in init(). Instead, skip the home-based paths (~/.fxrc.js and ~/.config/fx/.fxrc.js) when the home directory is unavailable. XDG_CONFIG_HOME is still honored if explicitly set. Fixes antonmedv#397
antonmedv
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
$HOMEis not defined (e.g. running as a system user or in a minimal container),os.UserHomeDirreturns an error. PreviouslyreadFxrcpropagated this error, which caused a panic ininit():This change skips the home-based config paths (
~/.fxrc.jsand~/.config/fx/.fxrc.js) when the home directory is unavailable, instead of failing. The CWD-based.fxrc.jsandXDG_CONFIG_DIRSpaths still work, andXDG_CONFIG_HOMEis honored if explicitly set.Fixes #397