Skip to content

Update the bundled hiredis code to version 0.11.0.#5

Open
jparise wants to merge 1 commit into
antirez:masterfrom
jparise:hiredis-0.11.0
Open

Update the bundled hiredis code to version 0.11.0.#5
jparise wants to merge 1 commit into
antirez:masterfrom
jparise:hiredis-0.11.0

Conversation

@jparise

@jparise jparise commented Oct 5, 2012

Copy link
Copy Markdown

This fixes clang 4.1-based builds.

hiredis.c:696:31: error: second argument to 'va_arg' is of incomplete type 'void'
                    va_arg(ap,void);
                    ~~~~~~~~~~^~~~~
/usr/bin/../lib/clang/4.1/include/stdarg.h:35:50: note: expanded from macro 'va_arg'

Alternatively, hiredis could be included as a git submodule (as is done in hiredis-py).

@jparise

jparise commented Oct 23, 2012

Copy link
Copy Markdown
Author

@antirez, I'm interested in your opinion on the best approach here. Do you prefer the way I upgraded the hiredis library in-line, or should this redis-tools include hiredis as a git submodule?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant