Skip to content

AMW-590 Collection spelling and grammar checking for PRs#24

Open
RanabirChakraborty wants to merge 1 commit into
ansible-middleware:mainfrom
RanabirChakraborty:AMW-590
Open

AMW-590 Collection spelling and grammar checking for PRs#24
RanabirChakraborty wants to merge 1 commit into
ansible-middleware:mainfrom
RanabirChakraborty:AMW-590

Conversation

@RanabirChakraborty

Copy link
Copy Markdown
Member

@iweiss

iweiss commented Jul 10, 2026

Copy link
Copy Markdown

A couple of notes:

  • This should be documented in README.md with how to use this action, per-project settings, global settings, etc.
  • All files should be spell and grammar checked, not only .md, .rst and task names
  • You are excluding Andrew's name. If it gets flagged, maybe we need a base English dictionary



def _load_accepted_terms():
"""Load accepted spelling terms from the shared Vale vocabulary file."""

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe merged instead of shared?

SKIP_RULES = {
"write-good.TooWordy",
"write-good.Weasel",
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this be part of a shared vale.ini that can be overridden by a project's own vale.ini?

@RanabirChakraborty

Copy link
Copy Markdown
Member Author

@iweiss Thanks for the suggestions, Fixed it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants