Drop unused fedora.linux_system_roles dependency#46
Merged
Conversation
The collection does not use fedora.linux_system_roles in any module, plugin, or role. Keeping it as a galaxy.yml dependency forces consumers to resolve community.general to <12.0.0 via fedora.linux_system_roles, which blocks installing middleware_automation.keycloak alongside community.general >= 12. Fixes ansible-middleware/keycloak#365 Co-authored-by: Cursor <cursoragent@cursor.com>
RanabirChakraborty
added
the
bugfixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fedora.linux_system_rolescollection dependency fromgalaxy.yml,requirements.yml, andmolecule/requirements.yml.fedora.linux_system_rolesin any module, plugin, filter, or role.Problem
fedora.linux_system_rolesrequirescommunity.general:>=6.6.0,<12.0.0(RHEL 7 Python compatibility). Becausemiddleware_automation.commondeclares it as a transitive dependency, consumers cannot installmiddleware_automation.keycloak(or any collection depending oncommon) alongsidecommunity.general>= 12.0.0.Reported in ansible-middleware/keycloak#365 and related to linux-system-roles/linux-system-roles.github.io#137.
Breaking change / porting
Consumers that relied on transitive installation of
fedora.linux_system_rolesviamiddleware_automation.commonmust add it explicitly to their ownrequirements.ymlif they still need it.Test plan
ansible-galaxy collection installsucceeds without pullingfedora.linux_system_rolescommunity.general>= 12 alongsidemiddleware_automation.commonMade with Cursor