Skip to content

secretsmanager_secret: improve idempotency tests - #2364

Open
tremble wants to merge 1 commit into
ansible-collections:mainfrom
tremble:issues/2363
Open

secretsmanager_secret: improve idempotency tests#2364
tremble wants to merge 1 commit into
ansible-collections:mainfrom
tremble:issues/2363

Conversation

@tremble

@tremble tremble commented Dec 17, 2025

Copy link
Copy Markdown
Contributor
SUMMARY

Added comprehensive integration tests following the standard 4-step test pattern:

  1. Set Value (Check mode) - changed=True, object NOT updated
  2. Set Value - changed=True, object updated
  3. Set same Value (Check mode) - changed=False, object NOT updated
  4. Set same Value - changed=False, object NOT updated

Changes:

  • Added initial secret creation check mode test
  • Added description parameter idempotency tests (check mode and normal)
  • Added resource policy check mode and idempotency tests
  • Added comprehensive binary secret_type tests (creation, update, idempotency)
  • Added overwrite parameter idempotency tests
  • Added removal operation check mode and idempotency tests for both recovery windows
  • Improved immediate removal idempotency test
  • Added cleanup for binary secret in always block

These changes significantly improve test coverage for previously untested or partially tested parameters, bringing them in line with the documented testing standards.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

secretsmanager_secret

ADDITIONAL INFORMATION

🤖 Generated with Claude Code

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/79e73c2c42d34a76b2d031498b80c0fd

✔️ ansible-galaxy-importer SUCCESS in 3m 56s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 17s
✔️ ansible-test-splitter SUCCESS in 4m 21s
✔️ integration-community.aws-1 SUCCESS in 3m 44s
Skipped 21 jobs

@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b4d2a8ab7f3943cf8fcfc5b8cd2cde1b

✔️ ansible-galaxy-importer SUCCESS in 4m 42s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 07s
✔️ ansible-test-splitter SUCCESS in 4m 38s
integration-community.aws-1 FAILURE in 2m 35s
Skipped 21 jobs

Added comprehensive integration tests following the standard 4-step test pattern:
1. Set Value (Check mode) - changed=True, object NOT updated
2. Set Value - changed=True, object updated
3. Set same Value (Check mode) - changed=False, object NOT updated
4. Set same Value - changed=False, object NOT updated

Changes:
- Added initial secret creation check mode test
- Added description parameter idempotency tests (check mode and normal)
- Added resource policy check mode and idempotency tests
- Added comprehensive binary secret_type tests (creation, update, idempotency)
- Added overwrite parameter idempotency tests
- Added removal operation check mode and idempotency tests for both recovery windows
- Improved immediate removal idempotency test
- Added cleanup for binary secret in always block

These changes significantly improve test coverage for previously untested or
partially tested parameters, bringing them in line with the documented testing
standards.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@softwarefactory-project-zuul

Copy link
Copy Markdown
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dd66c9fd6c1b4fc2b67e482b6eeabf96

✔️ ansible-galaxy-importer SUCCESS in 4m 32s (non-voting)
✔️ build-ansible-collection SUCCESS in 11m 38s
✔️ ansible-test-splitter SUCCESS in 4m 22s
✔️ integration-community.aws-1 SUCCESS in 3m 34s
Skipped 21 jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant