feat(medialive): add Elemental MediaLive modules to community collection - #2318
feat(medialive): add Elemental MediaLive modules to community collection#2318buxell wants to merge 11 commits into
Conversation
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 37s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 51s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 35s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 40s (non-voting) |
|
I'm seeing two issues with this PR:
I've also asked for guidance in the #ansible-aws channel in Libera to help move this forward. |
|
@buxell If you rebase your PR, then the Documentation build failures should be fixed. The forum post you created is the best place to get help with the IAM permissions |
b4233e0 to
b360ae5
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 56s (non-voting) |
Adds new modules for AWS Elemental MediaLive management: - medialive_sdi_source: Manage SDI source configurations - medialive_node: Handle node operations - medialive_network: Configure network settings - medialive_input: Manage input configurations - medialive_cluster: Control cluster operations - medialive_channel_placement_group: Manage channel placement groups This enhancement enables comprehensive management of MediaLive resources through Ansible automation, supporting bring-your-own-device Elemental Anywhere systems. Co-authored-by: Sergey Papyan <spapyan@amazon.com> Co-authored-by: David Teach <dteach@amazon.com> Co-authored-by: Brenton Buxell <buxell@amazon.com>
b360ae5 to
4628e9a
Compare
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 35s (non-voting) |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 05s (non-voting) |
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 15s (non-voting) |
|
I have created a companion PR in the aws.terminator repository that adds the required MediaLive IAM permissions needed for these integration tests to pass. Once that PR is merged, the CI failures here should be resolved. This PR should now be ready for review. |
alinabuzachis
left a comment
alinabuzachis
left a comment
There was a problem hiding this comment.
@buxell Thank you for your impressive contribution. Would it make sense to you to split this PR into several ones to make the review process easier?
| @@ -0,0 +1,3 @@ | |||
| minor_changes: | |||
There was a problem hiding this comment.
For new modules you not need changelog fragments, so, please remove these.
| options: | ||
| cdi_input_specification: | ||
| description: | ||
| - Specification of CDI inputs for this channel |
There was a problem hiding this comment.
| - Specification of CDI inputs for this channel | |
| - Specification of CDI inputs for this channel. |
| suboptions: | ||
| resolution: | ||
| description: | ||
| - Maximum CDI input resolution |
There was a problem hiding this comment.
| - Maximum CDI input resolution | |
| - Maximum CDI input resolution. |
| suboptions: | ||
| password_param: | ||
| description: | ||
| - key used to extract the password from EC2 Parameter store |
There was a problem hiding this comment.
| - key used to extract the password from EC2 Parameter store | |
| - Key used to extract the password from EC2 Parameter store. |
| type: str | ||
| stream_name: | ||
| description: | ||
| - Stream name for RTMP destinations (URLs of type rtmp://) |
There was a problem hiding this comment.
| - Stream name for RTMP destinations (URLs of type rtmp://) | |
| - Stream name for RTMP destinations (URLs of type rtmp://). |
| suboptions: | ||
| password_param: | ||
| description: | ||
| - key used to extract the password from EC2 Parameter store |
There was a problem hiding this comment.
| - key used to extract the password from EC2 Parameter store | |
| - Key used to extract the password from EC2 Parameter store. |
| - 'DVBDASH_7_CLEAN_FEED' | ||
| feature_activations: | ||
| description: | ||
| - Feature Activations |
There was a problem hiding this comment.
| - Feature Activations | |
| - Feature Activations. |
| suboptions: | ||
| black_frame_msec: | ||
| description: | ||
| - Documentation update needed |
There was a problem hiding this comment.
| - Documentation update needed | |
| - Documentation update needed. |
| class MediaLiveWaiterFactory(BaseWaiterFactory): | ||
| '''Custom waiter factory for MediaLive channel placement group resources''' | ||
|
|
||
| @property |
There was a problem hiding this comment.
Can you please move this custom waiter to https://github.com/ansible-collections/amazon.aws/blob/main/plugins/module_utils/waiters.py?
There was a problem hiding this comment.
Got rid of custom waiters in favor of official ones
| ) | ||
|
|
||
|
|
||
| def do_update_channel(self, params): |
There was a problem hiding this comment.
Would it make sense to move some of the shared logic to a plugins/modules_utils/medialive.py file?
There was a problem hiding this comment.
I believe there isn't enough shared logic to make it worth it
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 3m 41s (non-voting) |
Hi @alinabuzachis. I am one of the contributors and I've taken over the shepherding of this PR from @buxell.
|
|
On a different note - could you possibly take a look at this PR as well, @alinabuzachis? I believe I've seen you review older PRs on |
|
Closing this in favor of #2353 |
4 participants
SUMMARY
Adds new modules for AWS Elemental MediaLive to enable infrastructure-as-code management of MediaLive resources. These modules support automation of MediaLive configurations including Elemental Anywhere (bring-your-own-device) setups.
The following modules are included in this PR:
ISSUE TYPE
COMPONENT NAME
aws.medialive
ADDITIONAL INFORMATION
These modules expand the AWS collection's coverage to include MediaLive services, particularly useful for organizations managing broadcast and streaming workflows through Ansible automation.
Testing completed:
Contributors: