Fix all_green_check.yml

[mandar242]

SUMMARY

ISSUE TYPE

• Bugfix Pull Request
• Docs Pull Request
• Feature Pull Request
• New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

[brahmanim]

@mandar242 @beeankha Please see PR #142, which includes some corrections for running Unit and Sanity tests.
Maybe its worted to merge this PR before, event if coverage tests are failing there.
Please let me know what is your opnion?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[brahmanim]

Just need to check why the SonarCloud scan job skipped

[beeankha]

Just need to check why the SonarCloud scan job skipped

The sonarcloud job has an explicit fork guard in all_green_check.yml. Since this PR comes from mandar242/amazon.cloud (fork), not ansible-collections/amazon.cloud (upstream), the if is false and GitHub marks the job skipped even though all_green passed. On pull_request events from a fork, workflows run in the fork context and org-level secrets (including ANSIBLE_COLLECTIONS_ORG_SONAR_TOKEN_CICD_BOT) are not available (as documented here). The scan should run fully after merge to main (push event on upstream), or if a maintainer pushes the branch to ansible-collections/amazon.cloud and opens/updates the PR from there, or via a maintainer workflow that runs from a trusted branch.

[brahmanim]

Just need to check why the SonarCloud scan job skipped

The sonarcloud job has an explicit fork guard in all_green_check.yml. Since this PR comes from mandar242/amazon.cloud (fork), not ansible-collections/amazon.cloud (upstream), the if is false and GitHub marks the job skipped even though all_green passed. On pull_request events from a fork, workflows run in the fork context and org-level secrets (including ANSIBLE_COLLECTIONS_ORG_SONAR_TOKEN_CICD_BOT) are not available (as documented here). The scan should run fully after merge to main (push event on upstream), or if a maintainer pushes the branch to ansible-collections/amazon.cloud and opens/updates the PR from there, or via a maintainer workflow that runs from a trusted branch.

Thank you @beeankha, for the clarification. Althought I understand our limitation with using secrets from a forked repository, that will allow us to merge new code with lower code coverage, counting on the fact that someone will have to fix it later.