Re-run FunctionEnvironmentUpdate when Lambda changes#6920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6919
Problem
When the Lambda's environment is updated through the main
Functionresource,FunctionEnvironmentUpdatedoes not re-run. Its inputs (environment,functionName, etc.) are unchanged, so Pulumi skips it — even though the underlying Lambda was just updated.That means env vars added via
addEnvironment()are not reconciled: they can be left stale on the function or out of sync with what the resource expects.Solution
Pass
function.lastModifiedintoFunctionEnvironmentUpdateas a newfunctionLastModifiedinput. AWS updates this timestamp whenever the Lambda changes, so Pulumi treats it as an input change and re-runs the custom resource's update.Changes
this.function.lastModifiedthroughFunction.addEnvironment()infunction.tsfunctionLastModifiedto the TypeScript provider inputsFunctionLastModifiedto the Go resource inputs structTesting
I reproduced the bug with this code and ensured it was fixed with this change
fn.addEnvironment()(e.g. function withurl: true)