fix: Resolve small sync/async transform inconsistency, broaden integration coverage#72
Merged
Merged
Conversation
… for v41,v42 * add make transform target * add batch=10 to async client * run transform
Its more convinient for dev installation. The installation was copied from setup.yml by mistake.
Reuses the same cassettes to verify sync and async clients issue equivalent requests. Patches vcrpy's MockClientResponse.release to be async (real aiohttp returns an awaitable; the stub returns None, which dataclass_rest's `await response.release()` cannot handle). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Get rid of annoying warnings:
tests/base/test_client_async.py: 4 warnings
tests/integration/test_declarative.py: 31 warnings
/Users/azryve/src/github/annetbox/.venv/lib/python3.14/site-packages/pytest_asyncio/plugin.py:847: DeprecationWarning: 'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16
policy = asyncio.get_event_loop_policy()
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================ 104 passed, 889 warnings in 6.58s ============================================================
Tishka17
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
transform_to_sync.pywas resulting in a small diff. So I setbatch_size=10everywhere.Summary
dcim_all_interfacesusing different batch_size between sync and async clients on v41/v42dcim_all_interfacesto the integration test fixtures across versionstest_async_api_call, mirroringtest_sync_api_callagainst the same VCR cassettes so both client flavors are verified to issue equivalent requests and produce equivalent resultspytest-asyncioto 1.3.0 to support the new async testsMakefilefor local dev