fix: keep OAuth auth env declarative across restarts - #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Studio ADM 5 full Infra E2E exposed a repeat-
Infra Upfailure for Supabase OAuth projects. The generated Auth Deployment canonically ownsAPI_EXTERNAL_URL,GOTRUE_SITE_URL,GOTRUE_URI_ALLOW_LIST, andGOTRUE_JWT_ISSUERthroughconfigMapKeyRef, but OAuth reconciliation later replaced those entries with literal values viakubectl set env deployment/auth.On the next Infra Up,
kubectl applyattempted to restorevalueFromwhile the live Deployment still carriedvalue, producing invalid Kubernetes env entries with bothvalueandvalueFrom.Changes
kubectl set env deployment/authvalueFrom-backed and the generated up script never imperatively replaces themValidation context
The failure was reproduced by Studio's two-project Minikube/Supabase E2E on the second OAuth-project startup after credentials had been stored in Vault and trusted host resolution was intentionally unavailable. Initial project provisioning, Supabase migrations, Vault/OAuth setup, Studio web smoke, generated-app web E2E, and unit/static gates all completed before this restart-specific failure.
Roadmap context: ankhorage/studio#120