stdlib: replace remaining hand-rolled stdlib reimplementations - #386
Merged
Conversation
Covers everything left after the earlier slices/strings PR: builtin min/max clamps, cmp.Or fallback chains, strconv conversions, encoding/json, net/url, crypto/rand.Text, backoff-based retry, and one errors.Join fix for a lossy multi-error return. Behavior-preserving; findings were adversarially verified (equivalence + validity) before applying. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
stripAnsi was a pure one-line pass-through added by the prior commit; call ansi.Strip directly at all 21 call sites instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min/maxclamps (20),cmp.Orfallback chains (5),strconvconversions (4),encoding/json(2),net/url(2),time/backoff-based retry (2),crypto/rand.Text(1),os/exec.LookPath(1),log/slog.WithAttrs(1), and oneerrors.Joinfix for a lossy multi-error return inworkstream/manager.Test plan
go build ./...go vet ./...go test ./...gofmt -lclean on all touched files🤖 Generated with Claude Code