embedder: tolerate float rounding at similarity bounds - #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The similarity integration test asserted cosine similarity fell within a hard [min, max] range, with max exactly 1.0. Cosine similarity of identical embeddings is mathematically 1.0 but floating-point accumulation in the dot product and norms yields 1.0000000000000002, one ULP above 1.0, so the strict upper-bound check failed.
The bound checks now tolerate rounding at the edges using gonum's ULP comparison (scalar.EqualWithinULP) rather than a hand-rolled epsilon, and the failure message prints full precision instead of a rounded value that masked the real number.