jira: add read and list support for the per-issue layout - #370
Open
anish749 wants to merge 1 commit into
Open
Conversation
`pigeon list -p jira -a X` printed top-level project keys as if they were conversations; `pigeon read -p jira -a X -c KEY` fell through to the slack/whatsapp conversation flow and silently failed. Both gaps remained after #365 split issues from comments into per-issue dirs. - paths.JiraIssueFile gets Key() and CommentsFile() so layout knowledge (per-issue dir name, sibling comments file) stays in the registry. - paths.JiraIssueFileGlobs / JiraIssueFileGlobsForKey expose the rg glob shape, mirroring DriveMetaFileGlobsSince. - read.ListJiraIssues / FindJiraIssue do discovery via GlobFiles and return typed JiraIssueFile values via Classify, no path string manipulation in the consumer. - commands/list.go listJiraAccount prints flat issue keys. - commands/read.go runReadJira streams issue.jsonl + comments.jsonl through modelv1.Parse / Marshal. Round-trip validates structure on read; missing comments.jsonl is tolerated. go test ./..., go vet ./..., gofmt clean.
anish749
force-pushed
the
worktree-jira-read-list
branch
from
May 28, 2026 21:43
cac8d4e to
402acf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #365 split Jira issues from comments into per-issue directories, two read-side gaps remained:
pigeon list -p jira -a Xfell through tos.ListConversationsand printed top-level project keys (ENG, OPS) as if they were conversations.pigeon read -p jira -a X -c KEYfell through to the slack/whatsapp conversation flow and silently failed.Solution
paths.JiraIssueFile: addKey()andCommentsFile()so the per-issue dir name and sibling-comments fact stay inside the typed registry.paths.JiraIssueFileGlobs/JiraIssueFileGlobsForKey: expose the rg glob shape (mirrorsDriveMetaFileGlobsSince).read.ListJiraIssues/FindJiraIssue: discovery viaGlobFiles, results routed throughpaths.Classifyto typedJiraIssueFilevalues — no path-string manipulation in consumers.commands/list.golistJiraAccount: prints flat issue keys.commands/read.gorunReadJira: streamsissue.jsonl+comments.jsonlthroughmodelv1.Parse/Marshal. The round-trip validates structure on read; missingcomments.jsonlis tolerated. Rejects--date/--last/--sinceupfront.Tests
paths/jira_test.go:Key(),CommentsFile(), glob shape.read/jira_test.go: List + Find with on-disk fixture, ambiguous-cross-projects guard.commands/list_test.go,commands/read_test.go: end-to-end viaPIGEON_DATA_DIRoverride;streamModelLinesparse-error and tolerate-missing cases.go test ./...,go vet ./...,gofmtclean.Context
Replaces #325, which was built against the pre-#365 single-file-per-issue layout and is now obsolete.