store: scope --date thread orphan dump to the requested day - #358
Closed
anish749 wants to merge 1 commit into
Closed
store: scope --date thread orphan dump to the requested day#358anish749 wants to merge 1 commit into
anish749 wants to merge 1 commit into
Conversation
Owner
Author
|
Superseded by #363 — the right fix is to rebuild the read pipeline around thread completion (filter → complete → dedupe → sort → interleave), not patch the orphan-dump path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pigeon read --date Xreturned data even when the conversation had no date file for X.interleaveThreadsalways dumped every thread file whose parent wasn't in the selection, leaking parents and replies from unrelated days into a single-day read.Solution
Pass the requested date through to
interleaveThreads. When set, the orphan-dump fallback drops the cross-date parent and keeps only replies whose ts falls on that day.--sinceand the default window still get the unbounded fallback (their existing post-filter trims by ts).Tests
TestReadConversation_Date_NoFile_DoesNotDumpThreads— new regression: thread file from another day must not surface for--date Xwhen X has no date file.TestInterleaveThreads_ParentNotInDateFilesstill passes (cross-date reply on requested day still surfaces).--sinceorphan tests unchanged.