fix: validate calendar event date attribution - #268
Open
anish749 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calendar events are currently attributed to dates using
DatesForStorage(), which should handle multi-day events by returning all dates the event spans. However, the original bug description states "Right now we used a start date" — indicating there's confusion or a potential edge case with how timed events' end dates are handled.Key concern: For timed events (not all-day events), the current implementation includes the end date as inclusive. This creates a semantic ambiguity:
Proposed Solution
Clarify end date semantics for timed events: The end date should be treated as exclusive (like all-day events already are per Google Calendar API), so events ending at midnight are not attributed to that final date.
Add validation tests: Create test cases that verify:
Document the convention: Add doc comments clarifying that calendar events are stored across all dates they occur on, with consistent end date semantics.
Example
This ensures multi-day events are correctly attributed to the dates they actually occupy.